slurp: fix use-after-free crash on exit#60751
Open
npmania wants to merge 1 commit into
Open
Conversation
send_frame() overwrote output->frame_callback without destroying the previous wl_surface_frame() callback. The orphaned callback's listener could still fire after its output was freed during teardown, crashing slurp on exit. Backport of upstream 414760a (fixes emersion/slurp#177), which landed after the 1.5.0 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
slurp 1.5.0 has a use-after-free in
send_frame(): it overwritesoutput->frame_callbackwithout destroying the previouswl_surface_frame()callback, so the orphaned callback's listener can fire on a freedoutputduring teardown and crash slurp on exit. Reported and fixed upstream in emersion/slurp@414760a (fixes emersion/slurp#177), which landed after v1.5.0 was tagged, so the current release is affected. The crash is intermittent (depends on whether a frame callback is in flight at exit); for me it hit about half the time.