Skip to content

Offcanvas must not enforce focus if option 'scroll' is true#33445

Closed
GeoSot wants to merge 2 commits into
mainfrom
gs-regression-allow-offcanvas-to-not-enforce-focus
Closed

Offcanvas must not enforce focus if option 'scroll' is true#33445
GeoSot wants to merge 2 commits into
mainfrom
gs-regression-allow-offcanvas-to-not-enforce-focus

Conversation

@GeoSot
Copy link
Copy Markdown
Member

@GeoSot GeoSot commented Mar 23, 2021

No description provided.

@GeoSot GeoSot requested a review from a team as a code owner March 23, 2021 16:51
@GeoSot GeoSot marked this pull request as draft March 23, 2021 22:39
@GeoSot GeoSot force-pushed the gs-regression-allow-offcanvas-to-not-enforce-focus branch from f2d1492 to 1bb1df3 Compare March 23, 2021 23:48
@GeoSot GeoSot changed the title Offcanvas option to enforce focus or not Offcanvas must not enforce focus if option 'scroll' is true Mar 24, 2021
@XhmikosR
Copy link
Copy Markdown
Member

This doesn't seem quite right yet; if you go to the docs page and click on the first example buttons, the live example will close.

@GeoSot GeoSot closed this Apr 18, 2021
@GeoSot
Copy link
Copy Markdown
Member Author

GeoSot commented Apr 18, 2021

Start again on #33677, keeping only the proper change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants