Skip to content

v5: Vertical pills fix on mobile#31785

Merged
XhmikosR merged 2 commits into
mainfrom
js-vertical-tabs-no-grid
Sep 29, 2020
Merged

v5: Vertical pills fix on mobile#31785
XhmikosR merged 2 commits into
mainfrom
js-vertical-tabs-no-grid

Conversation

@mdo
Copy link
Copy Markdown
Member

@mdo mdo commented Sep 28, 2020

Change grid classes to utilities to make vertical nav example more resilient to narrow viewports.

/cc @XhmikosR

Fixes #31771

Non-whitespace diff: https://github.com/twbs/bootstrap/pull/31785/files?w=1
Preview: https://deploy-preview-31785--twbs-bootstrap.netlify.app/docs/5.0/components/navs/#javascript-behavior

@XhmikosR
Copy link
Copy Markdown
Member

@mdo you want this patch in alpha 2?

@mdo
Copy link
Copy Markdown
Member Author

mdo commented Sep 28, 2020

Your call, @XhmikosR :).

@XhmikosR
Copy link
Copy Markdown
Member

Let's add it to alpha 2, I'm hoping to rebuild everything anyway :)

@MartijnCuppens MartijnCuppens changed the title Fixes #31771 v5: Vertical pills fix on mobile Sep 28, 2020
@XhmikosR XhmikosR merged commit 1872133 into main Sep 29, 2020
@XhmikosR XhmikosR deleted the js-vertical-tabs-no-grid branch September 29, 2020 07:11
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
…silient to narrow viewports (twbs#31785)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v5 vertical pills regression

2 participants