Skip to content

upgrade: history package upgrade for Solid 2.0#868

Open
davedbase wants to merge 3 commits into
solidjs-community:nextfrom
davedbase:update/v2/history
Open

upgrade: history package upgrade for Solid 2.0#868
davedbase wants to merge 3 commits into
solidjs-community:nextfrom
davedbase:update/v2/history

Conversation

@davedbase
Copy link
Copy Markdown
Member

@davedbase davedbase commented May 4, 2026

Updates peer dependencies to solid-js@^2.0.0-beta.10 and @solidjs/web@^2.0.0-beta.10 and adapts the implementation and tests to Solid 2.0's new reactive model: automatic batching removes the need for explicit batch() calls, isServer now comes from @solidjs/web, and createMemo's initial prev value is undefined on first call rather than the supplied init argument. Tests are restructured to write signals outside owned scopes and use flush() before reading derived memo values.

Summary by CodeRabbit

  • Breaking Changes

    • Updated to Solid.js v2.0 (beta.14)
    • Moved isServer import to @solidjs/web
    • Removed batch() from undo/redo operations
    • Updated memo initialization behavior
  • Documentation

    • Updated examples for Solid 2.0 batching behavior
  • Tests

    • Added SSR test coverage

Review Change Stack

@davedbase davedbase added this to the Solid 2.0 Migration milestone May 4, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

🦋 Changeset detected

Latest commit: 4aab877

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/history Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davedbase davedbase marked this pull request as ready for review May 23, 2026 21:14
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2530e114-eafe-403b-a8cf-31c939c86772

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant