ext/uri: Fix static build on Windows by defining LEXBOR_STATIC#22165
Open
luthermonson wants to merge 1 commit into
Open
ext/uri: Fix static build on Windows by defining LEXBOR_STATIC#22165luthermonson wants to merge 1 commit into
luthermonson wants to merge 1 commit into
Conversation
ext/uri is always built statically (false /* never shared */ in EXTENSION()) and includes the bundled lexbor headers via /I ext/lexbor. On Windows, lexbor's LXB_API macro defaults to __declspec(dllimport) when LEXBOR_STATIC is not defined, producing LNK2019 unresolved external symbol errors for every lxb_* function referenced from ext/uri when linking PHP statically. Add /D LEXBOR_STATIC to CFLAGS_URI next to the existing URI_STATIC_BUILD flag, which serves the analogous role for ext/uri's own API decoration. This matches how ext/uri already handles its own static-linkage with URI_STATIC_BUILD - the lexbor side was simply missing.
luthermonson
changed the title
Member
|
I know nothing about Windows. Should / Must this be fixed in ext/lexbor instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/uriis always built statically and pulls in the bundled lexbor headers via/I ext/lexbor. On Windows, lexbor'sLXB_APImacro defaults to__declspec(dllimport)whenLEXBOR_STATICisn't defined. As a result, when PHP itself is linked statically (no DLL) on Windows, everylxb_*symbol referenced fromext/urifails to resolve: