stream: switch to internal sleep binding

[aduh95]

I don't think there was any reason to maintain two duplicate implementations, my guess is that we simply forgot about the existing util.

node/lib/internal/util.js

Lines 610 to 617 in 8d0a3b8

	function sleep(msec) {
	// Lazy-load to avoid a circular dependency.
	if (validateUint32 === undefined)
	({ validateUint32 } = require('internal/validators'));
	validateUint32(msec, 'msec');
	_sleep(msec);
	}

The only limitation seems to be that the util only supports sleeping for 49 days

[nodejs-github-bot]

Review requested:

• @nodejs/streams

[MattiasBuelens]

The Utf8Stream code from was originally ported from SonicBoom, which depended on atomic-sleep. The atomic-sleep implementation appears to have been copied verbatim in the original PR. So indeed, this looks like a small oversight while porting.

The only limitation seems to be that the util only supports sleeping for 49 days

That shouldn't be a problem. The only usages of this helper are sleep(BUSY_WRITE_TIMEOUT) calls, and that's set to just 100ms. 😉

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (8d0a3b8) to head (c5f9088).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #63611   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files         730      730           
  Lines      234782   234763   -19     
  Branches    43953    43955    +2     
=======================================
- Hits       211993   211976   -17     
- Misses      14501    14504    +3     
+ Partials     8288     8283    -5     

Files with missing lines	Coverage Δ
lib/internal/streams/fast-utf8-stream.js	74.80% <100.00%> (+0.23%)	⬆️

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73809/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73819/