-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
crypto: add crypto::GetSSLCtx API for addon access to OpenSSL contexts #62254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+171
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| #include <node.h> | ||
| #include <openssl/ssl.h> | ||
|
addaleax marked this conversation as resolved.
|
||
|
|
||
| namespace { | ||
|
|
||
| // Test: extract SSL_CTX* from a SecureContext object via | ||
| // node::crypto::GetSSLCtx. | ||
| void GetSSLCtx(const v8::FunctionCallbackInfo<v8::Value>& args) { | ||
| v8::Isolate* isolate = args.GetIsolate(); | ||
| v8::Local<v8::Context> context = isolate->GetCurrentContext(); | ||
|
|
||
| SSL_CTX* ctx = node::crypto::GetSSLCtx(context, args[0]); | ||
| if (ctx == nullptr) { | ||
| isolate->ThrowException(v8::Exception::Error( | ||
| v8::String::NewFromUtf8( | ||
| isolate, "GetSSLCtx returned nullptr for a valid SecureContext") | ||
| .ToLocalChecked())); | ||
| return; | ||
| } | ||
|
|
||
| // Verify the pointer is a valid SSL_CTX by calling an OpenSSL function. | ||
| const SSL_METHOD* method = SSL_CTX_get_ssl_method(ctx); | ||
| if (method == nullptr) { | ||
| isolate->ThrowException(v8::Exception::Error( | ||
| v8::String::NewFromUtf8(isolate, | ||
| "SSL_CTX_get_ssl_method returned nullptr") | ||
| .ToLocalChecked())); | ||
| return; | ||
| } | ||
|
|
||
| args.GetReturnValue().Set(true); | ||
| } | ||
|
|
||
| // Test: passing a non-SecureContext value returns nullptr. | ||
| void GetSSLCtxInvalid(const v8::FunctionCallbackInfo<v8::Value>& args) { | ||
| v8::Isolate* isolate = args.GetIsolate(); | ||
| v8::Local<v8::Context> context = isolate->GetCurrentContext(); | ||
|
|
||
| SSL_CTX* ctx = node::crypto::GetSSLCtx(context, args[0]); | ||
| args.GetReturnValue().Set(ctx == nullptr); | ||
| } | ||
|
|
||
| void Initialize(v8::Local<v8::Object> exports, | ||
| v8::Local<v8::Value> module, | ||
| v8::Local<v8::Context> context) { | ||
| NODE_SET_METHOD(exports, "getSSLCtx", GetSSLCtx); | ||
| NODE_SET_METHOD(exports, "getSSLCtxInvalid", GetSSLCtxInvalid); | ||
| } | ||
|
|
||
| } // anonymous namespace | ||
|
|
||
| NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize) | ||
Uh oh!
There was an error while loading. Please reload this page.