Skip to content

gyp: aix: change gcc version so CXX="ccache g++" works#61464

Merged
sxa merged 1 commit into
nodejs:mainfrom
sxa:AIX_CXX_spaces
Jan 23, 2026
Merged

gyp: aix: change gcc version so CXX="ccache g++" works#61464
sxa merged 1 commit into
nodejs:mainfrom
sxa:AIX_CXX_spaces

Conversation

@sxa
Copy link
Copy Markdown
Member

@sxa sxa commented Jan 21, 2026

Closes #61443

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 21, 2026

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 21, 2026
@sxa
Copy link
Copy Markdown
Member Author

sxa commented Jan 21, 2026

I've done a quick test of this with setting CXX to ccache g++ and leaving it unset so it defaults to g++ and it looks ok (based on looking at the first few lines from make showing the expected values, and the libpath parameter being correct in one of the generated .mk files)

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 21, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70943/

@sxa
gyp: aix: change gcc version detection so CXX="ccache g++" works
b606fd7 
Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa
Copy link
Copy Markdown
Member Author

sxa commented Jan 21, 2026

(Force push purely to add "detection" to the commit title)

@sxa sxa requested a review from richardlau January 21, 2026 16:20
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 21, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70946/

@sxa sxa self-assigned this Jan 22, 2026
@sxa sxa marked this pull request as ready for review January 22, 2026 16:12
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 23, 2026
@sxa sxa removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2026
@sxa sxa merged commit b0ae89c into nodejs:main Jan 23, 2026
85 checks passed
@sxa
Copy link
Copy Markdown
Member Author

sxa commented Jan 23, 2026

Landed in b0ae89c

aduh95 pushed a commit that referenced this pull request Jan 24, 2026
@sxa @aduh95
gyp: aix: change gcc version detection so CXX="ccache g++" works
8abd54f 
Signed-off-by: Stewart X Addison <sxa@ibm.com>
PR-URL: #61464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
islandryu pushed a commit to islandryu/node that referenced this pull request Jan 25, 2026
@sxa @islandryu
gyp: aix: change gcc version detection so CXX="ccache g++" works
374b961 
Signed-off-by: Stewart X Addison <sxa@ibm.com>
PR-URL: nodejs#61464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@github-actions github-actions Bot mentioned this pull request Jan 25, 2026
Merged
sxa added a commit to sxa/node that referenced this pull request Jan 26, 2026
@sxa
gyp: aix: change gcc version detection so CXX="ccache g++" works
3da3beb 
Signed-off-by: Stewart X Addison <sxa@ibm.com>
PR-URL: nodejs#61464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 27, 2026
@tmeijn