tools: revert to use @stylistic/eslint-plugin-js v3

[joyeecheung]

@stylistic/eslint-plugin-js v4 has been updated to ship ESM-only, which needs require(esm) support due to the monkey-patching we do in our eslint.config.mjs. The node-test-linter job in Jenkins still runs Node.js v20 which has not yet released unflagging of require(esm). Revert to use v3 for now until we upgrade the Node.js version used in the CI.

Refs: #57261
For an example of broken CI, see https://ci.nodejs.org/job/node-test-linter/59234/console

[github-actions]

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

[joyeecheung]

Arguably a better fix would be to make this less hacky

node/eslint.config.mjs

Lines 33 to 38 in a7f648c

	Module._resolveFilename = (request, parent, isMain, options) => {
	if (hacks.includes(request) && parent.id.endsWith('__placeholder__.js')) {
	return resolveEslintTool(request);
	}
	return ModuleResolveFilename(request, parent, isMain, options);
	};

Or to upgrade the CI to use Node.js v22. But the issue is now breaking the CI and this seems like the most no-brainer fix.

[aduh95]

You need to update the package-lock.json

[richardlau]

Ideally PR's such as #57261 would have a Jenkins CI run.

[targos]

What do you think about changing the workflow so it also runs with Node.js 20.x so we are more confident about the fix and less likely to have this kind of issues in the future?

[joyeecheung]

What do you think about changing the workflow so it also runs with Node.js 20.x so we are more confident about the fix and less likely to have this kind of issues in the future?

I am not sure how the Jenkins gets the Node.js versions, but if it's an easy fix, happy that someone else get it done ASAP instead.

[richardlau]

What do you think about changing the workflow so it also runs with Node.js 20.x so we are more confident about the fix and less likely to have this kind of issues in the future?

I am not sure how the Jenkins gets the Node.js versions, but if it's an easy fix, happy that someone else get it done ASAP instead.

On Jenkins the jenkins-workspace machines (which run the linter job among others) are setup via Ansible: nodejs/build#4032 (comment)

[targos]

Alternative that removes the use of require: #57315

[joyeecheung]

node-test-linter CI: https://ci.nodejs.org/job/node-test-linter/59242/

[jasnell]

I'm good with either approach. thanks for taking a look

[joyeecheung]

Landing it now to unbreak CI. We can revert it when the Node.js version gets updated or when #57315 lands

[nodejs-github-bot]

Landed in e05756f