Skip to content

lib: clean up references to GCed abort signals #55354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 12 commits into from
Oct 14, 2024
Merged

lib: clean up references to GCed abort signals #55354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
00dc205
lib: remove settled dependant signals when they are GCed
geeksilva97 Oct 10, 2024
220915b
test: test settled signals dropping
geeksilva97 Oct 10, 2024
85ac22a
fixup: typo
geeksilva97 Oct 11, 2024
9a7c5ce
fix: avoid holding strong reference on finalizers
geeksilva97 Oct 11, 2024
4b3ec8e
test: improve tests
geeksilva97 Oct 11, 2024
87ce721
lib: optmize finalizers logic
geeksilva97 Oct 11, 2024
3fb3765
test: ensure short-lived signals are GCed
geeksilva97 Oct 11, 2024
ba52b6b
refactor: rename variables for improving readability
geeksilva97 Oct 11, 2024
5f0939f
test: improve signal dropping test
geeksilva97 Oct 11, 2024
d3cc655
test: test settled signals when AbortSignal.any receives a composite …
geeksilva97 Oct 11, 2024
c1a1c2c
refactor: remove unneeded describe
geeksilva97 Oct 11, 2024
c749402
chore: address pr's comments
geeksilva97 Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view