Skip to content

test: reduce flakiness of test-assert-esm-cjs-message-verify#53967

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:unflake-esm-cjs-assert-message
Jul 21, 2024
Merged

test: reduce flakiness of test-assert-esm-cjs-message-verify#53967
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:unflake-esm-cjs-assert-message

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Jul 20, 2024 •
edited
Loading

I noticed some failures for this test (e.g. https://ci.nodejs.org/job/node-test-commit-linuxone/44599/nodes=rhel9-s390x/testReport/junit/(root)/-%20ensure%20the%20assert/ok_throwing_similar_error_messages_for_esm_and_cjs_files/) which seems to be related to the way the test was trying to remove temp files with some custom code, when in fact it doesn't need temp file at all to test what it's trying to test.

Fixes: #53962

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 20, 2024
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 21, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60488/

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 72 hours to land. label Jul 21, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 21, 2024

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 21, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit 036ff03 into nodejs:main Jul 21, 2024
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 21, 2024

Landed in 036ff03

@aduh95 aduh95 deleted the unflake-esm-cjs-assert-message branch July 21, 2024 17:44
targos pushed a commit that referenced this pull request Jul 28, 2024
@aduh95 @targos
test: reduce flakiness of test-assert-esm-cjs-message-verify
62f2371 
PR-URL: #53967
Fixes: #53962
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@aduh95 @RafaelGSS
test: reduce flakiness of test-assert-esm-cjs-message-verify
5cea7ed 
PR-URL: #53967
Fixes: #53962
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Aug 19, 2024
@aduh95 @marco-ippolito
test: reduce flakiness of test-assert-esm-cjs-message-verify
72bd501 
PR-URL: #53967
Fixes: #53962
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@marco-ippolito marco-ippolito mentioned this pull request Aug 19, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 19, 2024
@aduh95 @marco-ippolito
test: reduce flakiness of test-assert-esm-cjs-message-verify
9ddcb16 
PR-URL: #53967
Fixes: #53962
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Aug 19, 2024
@aduh95 @marco-ippolito
test: reduce flakiness of test-assert-esm-cjs-message-verify
6d0b8de 
PR-URL: #53967
Fixes: #53962
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 22, 2024
@tmeijn