node-api: make napi_ref for all value types to be experimental#47975
Closed
vmoroz wants to merge 5 commits into
Closed
node-api: make napi_ref for all value types to be experimental#47975vmoroz wants to merge 5 commits into
napi_ref for all value types to be experimental#47975vmoroz wants to merge 5 commits into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Contributor
gabrielschulhof
left a comment
gabrielschulhof
left a comment
There was a problem hiding this comment.
One minor doc request, otherwise LGTM.
toyobayashi
added a commit
to toyobayashi/emnapi
that referenced
this pull request
May 13, 2023
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
legendecas
approved these changes
May 16, 2023
github-actions
Bot
removed
the
request-ci
Collaborator
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
legendecas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47975 ✔ Done loading data for nodejs/node/pull/47975 ----------------------------------- PR info ------------------------------------ Title node-api: make `napi_ref` for all value types to be experimental (#47975) Author Vladimir Morozov (@vmoroz) Branch vmoroz:PR/napi_ref_all_values_experimental -> nodejs:main Labels c++, node-api, needs-ci Commits 5 - node-api: napi_ref for all value types is experimental - extract experimental behavior into a paragraph - update doc/api/n-api.md - fix lint-md issues - update doc/api/n-api.md Committers 2 - Vladimir Morozov - GitHub PR-URL: https://github.com/nodejs/node/pull/47975 Reviewed-By: Chengzhong Wu Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47975 Reviewed-By: Chengzhong Wu Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - update doc/api/n-api.md ℹ This PR was created on Fri, 12 May 2023 14:21:41 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/47975#pullrequestreview-1428929792 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47975#pullrequestreview-1429103385 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-05-16T17:58:27Z: https://ci.nodejs.org/job/node-test-pull-request/51830/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - update doc/api/n-api.md - Querying data for job/node-test-pull-request/51830/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5014193886 |
mhdawson
pushed a commit
that referenced
this pull request
May 18, 2023
PR-URL: #47975 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
|
Landed as 0063669 |
PR #45715 implemented a new versioning mechanism for Node-API module behavior, and it also introduced a new behavior for
napi_refto accept all value types. Since we are about to create new Node-API version 9, it was decided that thenapi_reffor all value types did not have enough "baking period" and it must remain in the experimental status for a while.In this PR we change the condition when the
napi_refis available for all types - it must be when the module targetsNAPI_VERSION_EXPERIMENTALversion. The Node-API documentation is also changed to reflect the experimental status of thisnapi_refbehavioral change.