Skip to content

v8.12.0 proposal#21593

Merged
MylesBorins merged 279 commits into
v8.xfrom
v8.12.0-proposal
Sep 11, 2018
Merged

v8.12.0 proposal#21593
MylesBorins merged 279 commits into
v8.xfrom
v8.12.0-proposal

Conversation

@MylesBorins
Copy link
Copy Markdown
Contributor

@MylesBorins MylesBorins commented Jun 29, 2018

trying a bit of a different approach here.

This is a release based on all the commits that are currently on v8.x-staging

There is a backlog of around 1200 commits that have not been audited for this release

https://gist.github.com/MylesBorins/078554dfc521fe945a6f45324206ec0e

This is a semver-minor release... as such we are going to want to bake longer with an r.c. process.

If you know of specific 8.x bugs that we should fix, any commits / prs from the above list, or features you want to be considered for this minor please comment on this issue and the @nodejs/lts and @nodejs/backporters team will review and land as appropriate.

If individuals don't see anything pressing for 8.x we'll ship it with what is in this PR. Assume that all currently open backport PRs are going to be triages, if they land this PR will be updated accordingly.


2018-09-11, Version 8.12.0 'Carbon' (LTS), @MylesBorins

Notable Changes

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. tools Issues and PRs related to the tools directory. v8.x labels Jun 29, 2018
@MylesBorins
Copy link
Copy Markdown
Contributor Author

/cc @nodejs/collaborators please chime in

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Jul 4, 2018

This would be my list of requested backports

[53f8563] - n-api: back up env before async work finalize (Gabriel Schulhof) #21129
[ba30d14] - n-api: throw when entry point is null (Gabriel Schulhof) #20779
[e61337d] - async_wrap: fix memory leak in AsyncResource (Michael Dawson) #20668
[b2d6eb7] - doc: cleanup n-api.md doc (Michael Dawson) #20430

@lpinca
Copy link
Copy Markdown
Member

lpinca commented Jul 8, 2018

#20786 should be added if possible.

@gabrielschulhof
Copy link
Copy Markdown
Contributor

#21688 will land on Monday and should also go in, IMO.

@MylesBorins
Copy link
Copy Markdown
Contributor Author

@mhdawson b2d6eb7 and e61337d landed cleanly. The other two require manual backports and I've flagged them in the PRs

@lpinca #20786 needs to be manually backported

@gabrielschulhof #21688 does not land cleanly. Most likely we should batch a bunch of n-api patches... would you be able to look into this?

@MylesBorins
Copy link
Copy Markdown
Contributor Author

if rebased against staging and added as many of the requested commits as possible from above.

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Jul 9, 2018

@gabrielschulhof would be great if you could land the n-api ones that did not land cleanly, looks likey you were the author of the original PRs so may be easiest for you to do the merge.

@gabrielschulhof
Copy link
Copy Markdown
Contributor

gabrielschulhof commented Jul 9, 2018 via email

@MylesBorins
Copy link
Copy Markdown
Contributor Author

MylesBorins commented