Fix Homebrew container install user#467
Merged
Merged
Conversation
Performance Report (macOS)
Legend
|
Performance Report (Linux) ➖
Legend
|
Test Coverage Report (Linux)
Coverage unchanged. |
Performance Report (Windows) ➖
Legend
|
Test Coverage Report (Windows)
Coverage unchanged. |
rzhao271
previously approved these changes
May 27, 2026
dmitrivMS
previously approved these changes
May 27, 2026
b2ee79c to
04c7c85
Compare
dmitrivMS
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the Homebrew setup commands in the
homebrew/brewcontainer as thelinuxbrewuser instead of root, while discovering thebrewexecutable from the container PATH at runtime.The container job still runs as root so GitHub Actions checkout/tooling can write to the mounted workspace, but recent
homebrew/brewimages have been brittle whenbrew installitself runs as root. PR #466 is currently failing before Rust setup/tests with Homebrew crashing while pouring theca-certificatesbottle:This PR keeps the existing container shape but switches the install step to:
That avoids hardcoding the Linuxbrew prefix while still avoiding root-owned Homebrew install behavior.
Validation
This is a CI-only workaround. The useful validation is the
ci-homebrew-containerActions job on this PR.