chore(bigquery-jdbc): move all tests to junit5#13279
Open
logachev wants to merge 4 commits into
Open
Conversation
![gemini-code-assist[bot]](https://ghub.bbstale.com/avatars/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates several integration test files from JUnit 4 to JUnit 5 (Jupiter), updating annotations like @BeforeClass to @BeforeAll and updating assertion imports. It also adds ITStatementTest to the ITPresubmitTests suite. The review feedback correctly identifies a compilation error in ITBigQueryJDBCTest due to missing static imports for the newly unqualified JUnit 5 assertions, and points out a redundant consecutive call to connection.close() in the same file.
Comment on lines
146
to
147
| connection.close(); | ||
| connection.close(); |
Contributor
There was a problem hiding this comment.
The connection.close() method is called twice consecutively. The second call is redundant and can be safely removed.
Suggested change
| connection.close(); | |
| connection.close(); | |
| connection.close(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some integration tests that were moved to this repo recently were not running because they still relied on junit4