Skip to content

internal/cpu: detect GFNI independently of AVX-512F#79438

Open
alexrios wants to merge 1 commit into
golang:masterfrom
alexrios:fix/internal-cpu-hasgfni-vex
Open

internal/cpu: detect GFNI independently of AVX-512F#79438
alexrios wants to merge 1 commit into
golang:masterfrom
alexrios:fix/internal-cpu-hasgfni-vex

Conversation

@alexrios
Copy link
Copy Markdown

@alexrios alexrios commented May 17, 2026

GFNI is exposed in VEX-encoded form (VGF2P8AFFINEQB on XMM/YMM) on every
x86 CPU that reports the GFNI bit (CPUID leaf 7 ECX bit 8) and supports
YMM (HasAVX). Only the EVEX-encoded form requires AVX-512.

Since CL 655280 imported the Green Tea scan kernel, X86.HasGFNI was
populated inside the "if X86.HasAVX512F { ... }" block, leaving it false
on hosts that have VEX-256 GFNI but no AVX-512:

  • Intel 12th-14th generation consumer CPUs (Alder/Raptor Lake) where
    AVX-512 is fuse-locked off to maintain ISA homogeneity with the
    E-cores.
  • Intel Atom-derived SKUs (Jasper/Elkhart Lake, N100/N200/N300-series)
    which have shipped GFNI since Tremont but have never had AVX-512.

These platforms can execute VGF2P8AFFINEQB on YMM natively but the cpu
package incorrectly reported HasGFNI=false.

Move the standalone GFNI detection out of the AVX-512 block and gate it
on HasAVX (which requires OSXSAVE + YMM OS support), matching the
existing pattern for HasVAES. The EVEX form continues to be reported
separately via HasAVX512GFNI.

Add HasGFNI to the GODEBUG=cpu.* options table so users have a kill
switch on hosts the previous (over-restrictive) gating implicitly hid.
Without this, the only way to disable HasGFNI on a non-AVX-512 host
would be the sledgehammer GODEBUG=cpu.avx=off.

Add a regression test that reads CPUID leaf 7 ECX bit 8 directly and
asserts HasGFNI is set when the hardware bit is set and AVX is
available; verified to fail on the buggy code on an i9-14900K. Add a
paired TestDisableGFNI that exercises the new GODEBUG kill switch, and
TestX86ifGFNIhasAVX / TestX86ifAVX512GFNIhasGFNI invariant tests
following the established pattern in cpu_x86_test.go.

Fixes #79437

@alexrios alexrios marked this pull request as ready for review May 17, 2026 01:31
GFNI is exposed in VEX-encoded form (`VGF2P8AFFINEQB` on XMM/YMM) on every x86 CPU that reports the GFNI bit (CPUID leaf 7 ECX bit 8) and supports YMM (`HasAVX`). Only the EVEX-encoded form requires AVX-512.

Since CL 655280 imported the Green Tea scan kernel, `X86.HasGFNI` was populated inside the `if X86.HasAVX512F { ... }` block, leaving it false on hosts that have VEX-256 GFNI but no AVX-512:

- Intel 12th–14th generation consumer CPUs (Alder/Raptor Lake) where AVX-512 is fuse-locked off to maintain ISA homogeneity with the E-cores.
- Intel Atom-derived SKUs (Jasper/Elkhart Lake, N100/N200/N300-series) which have shipped GFNI since Tremont but have never had AVX-512.

These platforms can execute `VGF2P8AFFINEQB` on YMM natively but the cpu package incorrectly reported `HasGFNI=false`.

Move the standalone GFNI detection out of the AVX-512 block and gate it on `HasAVX` (which requires OSXSAVE + YMM OS support), matching the existing pattern for `HasVAES`. The EVEX form continues to be reported separately via `HasAVX512GFNI`.

Add `HasGFNI` to the `GODEBUG=cpu.*` options table so users have a kill switch on hosts the previous (over-restrictive) gating implicitly hid. Without this, the only way to disable `HasGFNI` on a non-AVX-512 host would be the sledgehammer `GODEBUG=cpu.avx=off`.

Add a regression test that reads CPUID leaf 7 ECX bit 8 directly and asserts `HasGFNI` is set when the hardware bit is set and AVX is available; verified to fail on the buggy code on an i9-14900K. Add a paired `TestDisableGFNI` that exercises the new GODEBUG kill switch, and `TestX86ifGFNIhasAVX` / `TestX86ifAVX512GFNIhasGFNI` invariant tests following the established pattern in `cpu_x86_test.go`.

Fixes golang#79437.
@alexrios alexrios force-pushed the fix/internal-cpu-hasgfni-vex branch from dca1b2e to af1e060 Compare May 17, 2026 01:34
@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: af1e060) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/778680.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/778680.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/778680.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal/cpu: HasGFNI is incorrectly nested inside the HasAVX512F block

2 participants