cmd/compile: add size cache to StdSizes to avoid exponential compile time#79314
Open
hesam-oxe wants to merge 1 commit into
Open
cmd/compile: add size cache to StdSizes to avoid exponential compile time#79314hesam-oxe wants to merge 1 commit into
hesam-oxe wants to merge 1 commit into
Conversation
…time Added sizeCache map with RWMutex to StdSizes to memoize Sizeof results. This prevents exponential recomputation for deeply nested generic types. Fixes golang#78342
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
/verify-cla |
Author
|
@google-cla I've signed the Individual CLA with email |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
sizeCachemap withsync.RWMutextoStdSizesto memoizeSizeofresults for deeply nested generic types.Problem
When compiling deeply nested generic instantiations like:
StdSizes.Sizeofwas called recursively without caching, resulting inexponential time (8^N where N is nesting depth).
Root Cause
Sizeoffor*Structand*Arraytypes recursively computes sizesof their elements/fields. For nested generic types, the same underlying
type is recomputed millions of times.
Fix
sizeCache map[Type]int64andsync.RWMutextoStdSizesSizeofchecks the cache before computing, and stores results afterImpact
Fixes #78342