fix: use 0-based byte offset in ps1 encoding test failure message#2710
Draft
Copilot wants to merge 2 commits into
Draft
fix: use 0-based byte offset in ps1 encoding test failure message#2710Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment
fix: use 0-based byte offset in ps1 encoding test failure message
May 26, 2026
mnriem
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure message in
test_ps1_file_is_ascii_onlyreported "byte offset" but storedi + 1(1-based), creating an off-by-one inconsistency when debugging encoding failures.Change
tests/test_ps1_encoding.py: Replacei + 1withiso the recorded position is 0-based, matching the conventional meaning of "byte offset".