Skip to content

refactor: deduplicate SSL-Bump fixture in squid-config-security tests #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
May 21, 2026
Merged

refactor: deduplicate SSL-Bump fixture in squid-config-security tests #3480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7fc2c9
Initial plan
Copilot May 20, 2026
39b9931
refactor: deduplicate sslBumpBase fixture in security tests
Copilot May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 11 additions & 24 deletions src/squid-config-security.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ import { SquidConfig } from './types';
describe('defense-in-depth: rejects injected values', () => {
const defaultPort = 3128;

const sslBumpBase = {
domains: ['evil.com'],
port: defaultPort,
sslBump: true as const,
caFiles: { certPath: '/tmp/cert.pem', keyPath: '/tmp/key.pem' },
sslDbPath: '/tmp/ssl_db',
} satisfies Partial<Parameters<typeof generateSquidConfig>[0]>;

it('should reject newline in domain via validateDomainOrPattern', () => {
expect(() => {
generateSquidConfig({
Expand All @@ -18,42 +26,21 @@ describe('defense-in-depth: rejects injected values', () => {
// The assertSafeForSquidConfig guard should catch this.
const maliciousPattern = 'https://evil.com/path\nhttp_access allow all';
expect(() => {
generateSquidConfig({
domains: ['evil.com'],
port: defaultPort,
sslBump: true,
caFiles: { certPath: '/tmp/cert.pem', keyPath: '/tmp/key.pem' },
sslDbPath: '/tmp/ssl_db',
urlPatterns: [maliciousPattern],
});
generateSquidConfig({ ...sslBumpBase, urlPatterns: [maliciousPattern] });
}).toThrow(/SECURITY/);
});

it('should reject hash character in URL pattern (Squid comment injection)', () => {
const maliciousPattern = 'https://evil.com/path#http_access allow all';
expect(() => {
generateSquidConfig({
domains: ['evil.com'],
port: defaultPort,
sslBump: true,
caFiles: { certPath: '/tmp/cert.pem', keyPath: '/tmp/key.pem' },
sslDbPath: '/tmp/ssl_db',
urlPatterns: [maliciousPattern],
});
generateSquidConfig({ ...sslBumpBase, urlPatterns: [maliciousPattern] });
}).toThrow(/SECURITY/);
});

it('should reject semicolon in URL pattern (Squid token injection)', () => {
const maliciousPattern = 'https://evil.com/path;injected';
expect(() => {
generateSquidConfig({
domains: ['evil.com'],
port: defaultPort,
sslBump: true,
caFiles: { certPath: '/tmp/cert.pem', keyPath: '/tmp/key.pem' },
sslDbPath: '/tmp/ssl_db',
urlPatterns: [maliciousPattern],
});
generateSquidConfig({ ...sslBumpBase, urlPatterns: [maliciousPattern] });
}).toThrow(/SECURITY/);
});

Expand Down
Loading