List group: Better use of CSS var#37888
Merged
mdo merged 1 commit intoJan 16, 2023
Merged
Conversation
85 tasks
mdo
approved these changes
Jan 16, 2023
Member
|
Active state wasn't intentional, thanks for the clean up here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the good variables.
Remove some duplicate selectors inside the loop.
Tweak a bit the color used by each variable.
Rollback the
:activestate for the.list-group-item-action. Not sure about this one but I felt weird using this. I wasn't sure it was done on purpose, so I tried something. Let me know if you want me to change the color as it is right now in Bootstrap.Motivation & Context
Have a consistent
.activestate.Have some used code.
Type of changes
Checklist
npm run lint)Live previews
Related issues
NA