Visually-hidden: Remove position: absolute for captions#37533
Merged
Conversation
f3f2ad9 to
1f34551
Compare
mdo
approved these changes
Dec 29, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
position: absolute;from the visually hidden caption, tried to group it with all.visually-hidden. There's maybe a better way ?Motivation & Context
Main issue: a positioned (or floating) table caption is understood as an anonymous cell of a table. This behavior leads to have an undeclared cell between the
theadand thetbody. This leads to the issue: It removes theborder-collapse: collapse;effect. More explanations here.Visual issue
Bordered modifier without

.visually-hidden:Bordered modifier with

.visually-hidden:Table divider modifier without

.visually-hidden:Table divider modifier with

.visually-hidden:Here is the minimum code:
Type of changes
Checklist
npm run lint)Live previews
Related issues
NA