Skip to content

Progress page: remove toggle animation button#34787

Merged
XhmikosR merged 2 commits into
mainfrom
main-xmr-docs-rm-prog-button
Aug 21, 2021
Merged

Progress page: remove toggle animation button#34787
XhmikosR merged 2 commits into
mainfrom
main-xmr-docs-rm-prog-button

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR commented Aug 20, 2021

We don't use the same approach with a button on the Placeholders page.

Preview: https://deploy-preview-34787--twbs-bootstrap.netlify.app/docs/5.1/components/progress/#animated-stripes

We don't use the same approach with a button on the Placeholders page.
@XhmikosR XhmikosR force-pushed the main-xmr-docs-rm-prog-button branch from 3a79ca5 to 540f437 Compare August 20, 2021 15:26
@XhmikosR XhmikosR marked this pull request as ready for review August 20, 2021 15:26
@XhmikosR XhmikosR requested a review from a team as a code owner August 20, 2021 15:27
Copy link
Copy Markdown
Contributor

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Was this done on purpose for accessibility, maybe? Ping @patrickhlauke just in case 😄

@patrickhlauke
Copy link
Copy Markdown
Member

LGTM! Was this done on purpose for accessibility, maybe? Ping @patrickhlauke just in case 😄

nah, i'm pretty sure that was well before my time, and it was there mainly to dynamically demonstrate how adding the class started the animation. no concerns with removing it (as this obeys prefers-reduced-motion which in my book counts as a mechanism to pause/stop/hide animations)

@ffoodd
Copy link
Copy Markdown
Contributor

ffoodd commented Aug 20, 2021

:shipit:

@XhmikosR
Copy link
Copy Markdown
Member Author

The main reason for having the toggle button is that this animations are not GPU accelerated thus they crippled performance on low-end devices.

But since we do not have a button in Placeholders, this makes things consistent . We can bring it back if needed.

@XhmikosR XhmikosR merged commit 9e1d81a into main Aug 21, 2021
@XhmikosR XhmikosR deleted the main-xmr-docs-rm-prog-button branch August 21, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants