Regression on tooltip template creation process.#34628
Merged
Merged
Conversation
Member
|
Can you please add a test? |
Return if template content does not exist
GeoSot
force-pushed
the
gs-tooltip-regression-on-template-empty
branch
from
e96fe57 to
810cb4e
Compare
GeoSot
force-pushed
the
gs-tooltip-regression-on-template-empty
branch
from
aa237c5 to
47b21f6
Compare
Member
Author
|
Changed the way it acts, and added a test |
alpadev
reviewed
Jul 30, 2021
This comment has been minimized.
This comment has been minimized.
alpadev
approved these changes
Jul 30, 2021
alpadev
reviewed
Jul 30, 2021
Member
|
@GeoSot when was this introduced? If it's after 5.0.2 it's not a regression and we should probably skip the PR from the release notes too. |
GeoSot
added a commit
that referenced
this pull request
Aug 4, 2021
* Regression on tooltip template creation process. * check if template content does not exist, or given argument is empty * call `setContent()` once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return if template content does not exist (Ex: popover without title)set content only once over an existing tip element
Replicate
Go to https://twbs-bootstrap.netlify.app/docs/5.0/components/popovers/#four-directions open js console. Click popover button three times (open->close->open)
As the code tries to every time to set content, it fails to remove an already removed element