use :read-only css selector instead [readonly] for consistency#33642
Merged
Conversation
There are 5 places where [readonly] selector is used. I have replaced with :read-only for consistency. fix for twbs#33101
ffoodd
approved these changes
Apr 15, 2021
Contributor
ffoodd
left a comment
ffoodd
left a comment
There was a problem hiding this comment.
Looks good to me since :read-only support is aligned in our browser support.
We may have side effect since it's not targeting the attribute anymore (which one may have used inappropriately on any HTML element) but pseudo-class only applies when it makes sense, so I'd go for it.
XhmikosR
changed the title
:read-only css selector instead [readonly] for consistency
|
I think |
Contributor
|
@eter94 Please open a dedicated issue for us to track, as we won't reopen nor comment a merged PR to fix anything. Thanks for providing a test case though, that's vert appreciated. |
This was referenced Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 5 places where [readonly] selector is used. I have replaced with :read-only for consistency.
fixes #33101