Accept data-bs-body option in the configuration object as well

[GeoSot]

Refactor offcanvas to accept config.
In order to use a simple configuration I separated bs-body option to bs-scroll and bs-backdrop

Preview

[rohit2sharma95]

Left few comments, except them LGTM 👍

[XhmikosR]

I'd return false here.

[GeoSot]

I am not sure. In code if an element not exists, you don't want to count it as valid. right?

[XhmikosR]

But the check is for isDisabled. If the element doesn't exist then it can't be disabled?

[GeoSot]

Usually we check if a button/anchor/input (or another div) is disabled. Almost in any case it will not be null. The null check is for the 'just in case' situation
I can omitted if you find it more accurate

[XhmikosR]

I prefer being stricter :) That being said, the logic seems off to me for the aforementioned reason.

[GeoSot]

another proposal is to throw an exception on line 157.
No-one has checked all these before, so if there is any other opinion I would like to know in order to finalize this

@twbs/js-review

[rohit2sharma95]

IMO, if the DOM element does not exist it should not be considered as enabled. The absence of the DOM element is also like the disability 🤔

[rohit2sharma95]

LGTM 👍