Fix toggling modal when clicking on data-bs-toggle="modal"#32691
Merged
Conversation
Member
|
This seems right by me? Clicking the modal toggle should toggle the modal, not just show it. |
rohit2sharma95
force-pushed
the
rohit/main/modal-toggle
branch
from
967229a to
e845df6
Compare
XhmikosR
approved these changes
Jan 13, 2021
XhmikosR
changed the title
data-bs-toggle="modal"data-bs-toggle="modal"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32643