Skip to content

Expand visually-hidden-focusable so it can be used on a container, …#32440

Merged
XhmikosR merged 2 commits into
mainfrom
v5-focuswithin
Dec 15, 2020
Merged

Expand visually-hidden-focusable so it can be used on a container, …#32440
XhmikosR merged 2 commits into
mainfrom
v5-focuswithin

Conversation

@patrickhlauke
Copy link
Copy Markdown
Member

@patrickhlauke patrickhlauke commented Dec 11, 2020

…so the container becomes visible when focus is inside it / on one of its child elements.

Closes #32370

https://deploy-preview-32440--twbs-bootstrap.netlify.app/docs/5.0/helpers/visually-hidden/

Copy link
Copy Markdown
Contributor

@septatrix septatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Found a little typo ;D

Comment thread site/content/docs/5.0/helpers/visually-hidden.md Outdated
@XhmikosR XhmikosR requested a review from mdo December 14, 2020 09:00
Copy link
Copy Markdown
Contributor

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@ffoodd

This comment has been minimized.

@ffoodd
Copy link
Copy Markdown
Contributor

ffoodd commented Dec 14, 2020

@patrickhlauke just used this new feature on our own skip links, please have a look :)

@patrickhlauke
Copy link
Copy Markdown
Member Author

@patrickhlauke just used this new feature on our own skip links, please have a look :)

looking good

patrickhlauke and others added 2 commits December 15, 2020 09:08
@XhmikosR XhmikosR merged commit c2f67d7 into main Dec 15, 2020
@XhmikosR XhmikosR deleted the v5-focuswithin branch December 15, 2020 07:22
chalkygames123 added a commit to chalkygames123/front-end-template that referenced this pull request Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.visually-hidden-focusable should also apply to :focus-within

5 participants