Skip to content

RTL improvements#32436

Merged
XhmikosR merged 4 commits into
mainfrom
main-fod-RTL-patches
Dec 14, 2020
Merged

RTL improvements#32436
XhmikosR merged 4 commits into
mainfrom
main-fod-RTL-patches

Conversation

@ffoodd
Copy link
Copy Markdown
Contributor

@ffoodd ffoodd commented Dec 11, 2020

Fixes #32327

@ffoodd ffoodd force-pushed the main-fod-RTL-patches branch 2 times, most recently from a6a2281 to e181325 Compare December 11, 2020 14:21
@ffoodd ffoodd force-pushed the main-fod-RTL-patches branch from 5b077ae to f197325 Compare December 11, 2020 15:01
@ffoodd ffoodd marked this pull request as ready for review December 11, 2020 15:19
@ffoodd ffoodd requested review from a team as code owners December 11, 2020 15:19
@ffoodd
Copy link
Copy Markdown
Contributor Author

ffoodd commented Dec 11, 2020

FWIW it's only missing the JS tests, but it's tracked in #32330 too. So this PR might be considered as simple patches.

@XhmikosR
Copy link
Copy Markdown
Member

@ffoodd ffoodd force-pushed the main-fod-RTL-patches branch from f197325 to 801c79d Compare December 11, 2020 15:55
@FaridAghili
Copy link
Copy Markdown

@XhmikosR @ffoodd
Keyboard direction is fixed and works as expected in RTL.

Same should be done for touch too: here and here

@ffoodd ffoodd mentioned this pull request Dec 11, 2020
20 tasks
@ffoodd ffoodd force-pushed the main-fod-RTL-patches branch from 801c79d to 54d0b79 Compare December 14, 2020 08:02
@ffoodd
Copy link
Copy Markdown
Contributor Author

ffoodd commented Dec 14, 2020

Thanks @FaridAghili, fixed ;)

@ffoodd ffoodd mentioned this pull request Dec 14, 2020
@XhmikosR XhmikosR merged commit b85ca04 into main Dec 14, 2020
@XhmikosR XhmikosR deleted the main-fod-RTL-patches branch December 14, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTL bugs

3 participants