Skip to content

Remove TRANSITION_END from utils#32394

Merged
XhmikosR merged 4 commits into
mainfrom
main-xmr-js-rm-trans-end
Dec 10, 2020
Merged

Remove TRANSITION_END from utils#32394
XhmikosR merged 4 commits into
mainfrom
main-xmr-js-rm-trans-end

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR commented Dec 9, 2020

This was useful in v4-dev and back when we supported older browsers.

TODO:

  • Drop the variable completely from plugins?

@XhmikosR XhmikosR force-pushed the main-xmr-js-rm-trans-end branch from 5aab905 to 0688ddd Compare December 9, 2020 20:51
@XhmikosR XhmikosR marked this pull request as ready for review December 9, 2020 21:59
@XhmikosR XhmikosR requested a review from a team as a code owner December 9, 2020 21:59
@rohit2sharma95
Copy link
Copy Markdown
Contributor

What if you use 'transitionend' instead of TRANSITION_END in utils also? 🤔 Because now it is used everywhere else as a string.

@XhmikosR
Copy link
Copy Markdown
Member Author

TBH it mostly seems like unnecessary optimization right now. It made sense back when we supported more browsers.

@XhmikosR XhmikosR merged commit 1edec54 into main Dec 10, 2020
@XhmikosR XhmikosR deleted the main-xmr-js-rm-trans-end branch December 10, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants