Update bundle.js in tests/integration#32233
Merged
Merged
Conversation
Member
|
@rohit2sharma95 good catch! Yes, please change the other instance too. It seems I caused this regression here and never noticed it until a couple of days ago :/ What I don't get is
PS. Do you have an account on our Slack? If not, feel free to join and DM me :) |
a2ecb71 to
a01f1c7
Compare
Contributor
Author
|
Tooltip is working after you changed the path of the script because it is being initialized here: bootstrap/js/tests/integration/index.html Lines 67 to 69 in 5a8cd95 And carousel seems working on my local machine 🤔 |
Contributor
Author
|
It is being done in #31178 though |
Member
|
Yeah, but it shouldn't be sneaked it like that :) I'd rather merge it separately. I'll have a look tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Array.prototype.concat()instead of direct spreading nodelist.I am not sure if it should be done in this file also @XhmikosR
Ref: #32227 (comment)