Handle Chromium to run Karma#32178
Merged
Merged
Conversation
Member
|
@ffoodd don't we need a new karma launcher package for Chromium? EDIT: to answer my question, this might be already supported by the https://github.com/karma-runner/karma-chrome-launcher package we are using. |
Contributor
Author
|
Confirmed: https://github.com/karma-runner/karma-chrome-launcher#readme
The same for Firefox BTW, a single launcher works for ESR, Stable, DevEd and Nightly. |
Member
|
Marked it for backport too since it helps you and doesn't hurt having it :) I'll try to install Chromium on my VM and try this later to confirm it works. |
Member
|
OK, so I tested this on Windows and Chromium isn't detected. But on Linux Mint it works, so I guess it's fine :) |
XhmikosR
approved these changes
Nov 17, 2020
ghost
reviewed
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not have Chrome nor stable Firefox and am always using this locally to run tests.
Could also add Firefox Nightly or ESR but I guess Chromium is a first, better choice.