Fix TypeError when Bootstrap is included in head

[tidusIO]

I've added waiting for domContentLoaded event before extending jQuery. That's one possible solution to be sure, that data attributes of body can be read.

Fixes #31202

Preview: https://deploy-preview-32024--twbs-bootstrap.netlify.app/

[Johann-S]

Hi @tidusIO,

Thanks for your work 👍

The overall is good, it needs just a few unit tests

[tidusIO]

It would be useful having some tests mocking getjQuery or jquery in window object, so that the uncovered parts are covered.

I'm struggling a bit with mocking these parts.

EDIT: Oh I overlooked jquery.spec.js. The extensions should be already tested.

EDIT 2: I will try, if it really solves the problem with TurboLink :)

[tidusIO]

We still have the problem in event-handler.js, when calling getjQuery().

[tidusIO]

I would prefer a way like this: ff1fa49
It's much cleaner and there shouldn't be no problems. If we'd implement it with event listener, the problem could be, that the user has to wait for DOMContentLoaded at some places too.

[Johann-S]

it seems something decreased the minimum coverage required

[tidusIO]

Do you know, if coverage also includes js-test-jquery?

I think, we should find a solution, that js-test-karma and js-test-jquery create a combined coverage. Otherwise all parts, that use jQuery are not covered.

[Johann-S]

The coverage doesn't include the jQuery part.
I don't think it's really necessary since jQuery is a very small part of our codebase and the main goal of v5 is to work without jQuery

[tidusIO]

Okay, still not familiar enough with bootstrap codebase. I simply overlooked the /* istanbul ignore if */ statements.

[Johann-S]

Thanks for your hard work @tidusIO 👍

[XhmikosR]

Just to confirm, this should work with defer too?

[XhmikosR]

@tidusIO apart from my comment above, can you please make a CodePen with the scripts in head so that we can test?

[tidusIO]

Yes, I've replied your comment. I can, but probably not before Wednesday.

[XhmikosR]

NVM I tested it myself and it works as expected, thanks for the PR!

[rpokrovskij]

Bad decision. Jquery plugins should be loaded in developer defined order: there is convention that this order is maintained by script loading. How to control this order after you broke it with domContentLoaded ? What if every jquery plugin start doing it this way?

[NefedovIv]

Rly like last comment. We works with sharepoint onprem, and have a problem there. SP have own event model, many usefull events trigered before DOMContentLoaded without access to jquery bootstrap plagins. We spand a time for only understand that plagins extend performed in postponed format.