Rename Navs to Navs and Tabs#31965
Conversation
|
hah, had that issue of mine on my perennial "need to really do a PR when i find a minute..." pile. thanks, will review now. |
|
build fails. i believe you also need to change the |
|
i believe it also needs changing in the overview.md file for components (see the changes I had to make back when i renamed checks) 490acf6 edit: ah, i'm clearly talking rubbish since there's no overview for components...but yeah there's "some" other reference somewhere that makes this fail, hmmm... turns out, it was caused by other pages referring to the navs page which has now been renamed and was causing broken links |
as we have a precedent of "Checks and radios" for not capitalising beyond the first letter
| title: Navs and tabs | ||
| description: Documentation and examples for how to use Bootstrap's included navigation components. | ||
| group: components | ||
| aliases: "/docs/5.0/components/navs/" |
There was a problem hiding this comment.
I don't think we need this alias since v5 is a major version. I need to remember to drop any redundant redirects when we hist stable.
There was a problem hiding this comment.
might still be nice to keep around in case people come from older versions and just hacked the url with 5.0? not precious about it either way though
There was a problem hiding this comment.
We always followed this pattern when we released major/minor versions since the URLs change. I'd rather keep things clean because we can easily end up with hundreds of redirects.
3 participants
Fixes #31378
/cc @patrickhlauke