Skip to content

Fix disabled checkbox toggle buttons#31651

Merged
XhmikosR merged 4 commits into
twbs:mainfrom
Psixodelik:disabled-toggle-buttons-fix
Sep 29, 2020
Merged

Fix disabled checkbox toggle buttons#31651
XhmikosR merged 4 commits into
twbs:mainfrom
Psixodelik:disabled-toggle-buttons-fix

Conversation

@Psixodelik
Copy link
Copy Markdown
Contributor

@Psixodelik Psixodelik commented Sep 14, 2020

Hi

Fixed a bug from issue #31355

For convenience of managing the state "disabled" added variables to _variables.scss.

$form-check-input-disabled-opacity - the default opacity for input with the form-check-input class

$form-check-label-disabled-opacity - The opacity value for the label. By default copies the value from $ form-check-input-disabled-opacity

$form-check-btn-check-disabled-opacity - The opacity value for the checkbox toggle buttons. By default takes the opacity value for disabled button

Solved with a selector + because the order of input and label should not change

Demo: https://deploy-preview-31651--twbs-bootstrap.netlify.app/docs/5.0/forms/checks-radios/

Fixes #31355

@Psixodelik Psixodelik requested a review from a team as a code owner September 14, 2020 18:27
@Psixodelik Psixodelik changed the title fix disabled checkbox toggle buttons Fix disabled checkbox toggle buttons Sep 14, 2020
@MartijnCuppens
Copy link
Copy Markdown
Member

Do we have an example of disabled labels in our docs somewhere? If not could you add it?

@Psixodelik
Copy link
Copy Markdown
Contributor Author

@MartijnCuppens

Added examples to the documentation

Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slated for Alpha 3.

@XhmikosR XhmikosR merged commit 0cb880c into twbs:main Sep 29, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
* fix disabled checkbox toggle buttons

* add disabled checks-radios examples in documentation

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing styles for disabled toggle buttons

4 participants