Darken dropdown divider#31131
Merged
Merged
Conversation
currently, `$gray-200` is practically imperceptible. darkening to `$gray-600` which also roughly matches the dropdown border color (when against white)
Member
Author
|
Current look of divider: After this change: |
Member
Author
|
no backport, as it seems the divider wasn't a problem in v4 https://getbootstrap.com/docs/4.5/components/dropdowns/#dividers |
Contributor
|
LGTM, but also has the option of referring to |
mdo
reviewed
Jun 23, 2020
Member
Author
|
Using border color: |
mdo
approved these changes
Jun 23, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
currently, `$gray-200` is practically imperceptible. switch to reusing `$dropdown-border-color`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently,
$gray-200is practically imperceptible. darkening to$gray-600which also roughly matches the dropdown border color (when against white)