Fix event propagation from inactive and disabled dropdowns (#30510)#30511
Merged
XhmikosR merged 1 commit intoApr 7, 2020
Merged
Conversation
Member
|
Thanks for the PR but the default repo branch is master. Everything should
target the master branch and we backport it as needed.
…On Fri, Apr 3, 2020, 19:35 luktom ***@***.***> wrote:
@luktom <https://github.com/luktom> requested review from @twbs/js-review
on: #30511 <#30511> Fix event
propagation from inactive and disabled dropdowns (#30510
<#30510>) as a code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#30511 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNKSLNZQ4G2MKJQF33TRKYF3XANCNFSM4L4H3ALA>
.
|
Johann-S
approved these changes
Apr 7, 2020
Member
|
Would you mind @luktom to backport that in our |
Author
Member
|
I'm gonna merge this for now and add it to the v5 project until we have a PR against master too, thanks @luktom! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #30510 for details. Two new unit tests added. "npm run test" was finished without errors.