fix: prevent .netrc from overriding explicit PAT/OAuth credentials#951
Merged
Conversation
) Set session.trust_env = False when explicit credentials (PAT or OAuth) are provided, preventing ~/.netrc from silently overriding the Authorization header. Basic auth preserves trust_env = True since netrc is a valid credential source for that auth type. Github-Issue:#860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.trust_env = Falsewhen explicit PAT or OAuth credentials are configured~/.netrcfrom silently overriding theAuthorizationheadertrust_env = Truesince netrc is a valid credential source for that auth typeCloses #860
Test plan
test_jira_client_pat_disables_trust_env— PAT sets trust_env=Falsetest_jira_client_oauth_disables_trust_env— OAuth sets trust_env=Falsetest_jira_client_basic_auth_preserves_trust_env— Basic keeps trust_env=Truetest_confluence_client_pat_disables_trust_env— Confluence PAT sets trust_env=False