Handle whitespace-only certificate annotation#4760
Merged
Conversation
Without this change, a certificate annotation for a signed container that contains only whitespace will trigger a panic, because LoadCertificatesFromPEM doesn't throw an error with an empty or whitespace-only string. Thanks to Ziyu Lin for reporting this. Signed-off-by: Hayden <8418760+Hayden-IO@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4760 +/- ##
==========================================
- Coverage 40.10% 36.47% -3.63%
==========================================
Files 155 220 +65
Lines 10044 12766 +2722
==========================================
+ Hits 4028 4657 +629
- Misses 5530 7403 +1873
- Partials 486 706 +220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmurphy
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, a certificate annotation for a signed container that contains only whitespace will trigger a panic, because LoadCertificatesFromPEM doesn't throw an error with an empty or whitespace-only string.
Thanks to Ziyu Lin for reporting this.
Summary
Release Note
Documentation