Skip to content

Instructions for not using $inspect#333

Merged
jgerigmeyer merged 15 commits into
mainfrom
migration
Nov 18, 2025
Merged

Instructions for not using $inspect#333
jgerigmeyer merged 15 commits into
mainfrom
migration

Conversation

@mirisuzanne
Copy link
Copy Markdown
Member

Description

Instructions for moving away from $inspect

But I'm having trouble running the build or docs commands…

  • build gives me an error about the @import we use for testing legacy support.
  • docs gives me a confusing error building the final example in asset/output.scss, insisting that there's a missing {.

Copy link
Copy Markdown
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build gives me an error about the @import we use for testing legacy support.

That's an expected deprecation warning, but doesn't impact the build step.

docs gives me a confusing error building the final example in asset/output.scss, insisting that there's a missing {.

Hm, the Sass playground was reporting the same compilation error -- apparently there was some nonstandard whitespace that was causing an issue. I fixed that, but now there are other True-specific errors on yarn docs:

The `contains-string()` mixin must only be used once per `assert()`

When I remove the second contains-string, then:

Each `assert()` must contain one `output()`, and one `expect()` or `contains()`

Comment thread CHANGELOG.md Outdated
@mirisuzanne
Copy link
Copy Markdown
Member Author

@jgerigmeyer I made it so that multiple contains-string() expectations can be used in a single assertion, but maybe that's wrong. If we like it, we probably need to update the JS as well.

@jgerigmeyer
Copy link
Copy Markdown
Member

@jgerigmeyer I made it so that multiple contains-string() expectations can be used in a single assertion, but maybe that's wrong. If we like it, we probably need to update the JS as well.

@mirisuzanne I'm not sure I understand the tradeoffs (or what JS needs to change) well enough to weigh in.

@mirisuzanne
Copy link
Copy Markdown
Member Author

@jgerigmeyer test has been added, and fails as expected.

Copy link
Copy Markdown
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirisuzanne If this looks good to you, I can make another alpha release.

@mirisuzanne
Copy link
Copy Markdown
Member Author

@jgerigmeyer looks good. Expand that to contains() and put out another alpha?

Comment thread sass/data/_context.scss
Comment thread test/css/test.css Outdated
Comment thread package.json
@jgerigmeyer jgerigmeyer merged commit 2498fe7 into main Nov 18, 2025
3 checks passed
@jgerigmeyer jgerigmeyer deleted the migration branch November 18, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants