Skip to content

repl: add customizable error handling#62188

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
addaleax:repl-handle-errors-fn
Mar 12, 2026
Merged

repl: add customizable error handling#62188
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
addaleax:repl-handle-errors-fn

Conversation

@addaleax
Copy link
Copy Markdown
Member

@addaleax addaleax commented Mar 10, 2026

Whether or not an exception should be handled when it was thrown in the REPL's context but the REPL is already closed is something that will depend on the details of the specific REPL instance's use case.

Adding this option lets the REPL's creator control the details of this behavior.

This resolves a TODO recently added in bd3cba5.

@addaleax addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 10, 2026
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Mar 10, 2026
@addaleax
repl: add customizable error handling
64670a3 
Whether or not an exception should be handled when it
was thrown in the REPL's context but the REPL is already
closed is something that will depend on the details of
the specific REPL instance's use case.

Adding this option lets the REPL's creator control the
details of this behavior.

This resolves a TODO recently added in bd3cba5.
@addaleax addaleax force-pushed the repl-handle-errors-fn branch from 7aa0e38 to 64670a3 Compare March 10, 2026 16:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (ae228c1) to head (64980e1).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #62188   +/-   ##
=======================================
  Coverage   89.65%   89.66%           
=======================================
  Files         676      676           
  Lines      206546   206561   +15     
  Branches    39558    39552    -6     
=======================================
+ Hits       185179   185204   +25     
+ Misses      13485    13474   -11     
- Partials     7882     7883    +1
Files with missing lines Coverage Δ
lib/repl.js 94.01% <100.00%> (+0.04%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added the review wanted PRs that need reviews. label Mar 11, 2026
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 11, 2026 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/71701/ (💛)

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 12, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 12, 2026
@nodejs-github-bot nodejs-github-bot merged commit 5e3951e into nodejs:main Mar 12, 2026
74 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 12, 2026

Landed in 5e3951e

aduh95 pushed a commit that referenced this pull request Mar 25, 2026
@addaleax @aduh95
repl: add customizable error handling
474f494 
Whether or not an exception should be handled when it
was thrown in the REPL's context but the REPL is already
closed is something that will depend on the details of
the specific REPL instance's use case.

Adding this option lets the REPL's creator control the
details of this behavior.

This resolves a TODO recently added in bd3cba5.

PR-URL: #62188
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Mar 28, 2026
@addaleax @aduh95
repl: add customizable error handling
f85b9d9 
Whether or not an exception should be handled when it
was thrown in the REPL's context but the REPL is already
closed is something that will depend on the details of
the specific REPL instance's use case.

Adding this option lets the REPL's creator control the
details of this behavior.

This resolves a TODO recently added in bd3cba5.

PR-URL: #62188
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@github-actions github-actions Bot mentioned this pull request Mar 31, 2026
Merged
nodejs-github-bot added a commit that referenced this pull request Mar 31, 2026
@nodejs-github-bot
2026-04-01, Version 25.9.0 (Current)
c104d5a 
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add using scopes to AsyncLocalStorage (Stephen Belanger) #61674
benchmark:
  * (SEMVER-MINOR) add benchmarks for experimental stream/iter (James M Snell) #62066
cli:
  * (SEMVER-MINOR) add --max-heap-size option (tannal) #58708
crypto:
  * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
repl:
  * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188
  * (SEMVER-MINOR) remove dependency on domain module (Matteo Collina) #61227
sea:
  * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158
stream:
  * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066
test:
  * (SEMVER-MINOR) add tests for experimental stream/iter implementation (James M Snell) #62066
test_runner:
  * add exports option for module mocks (sangwook) #61727

PR-URL: #62522
aduh95 added a commit that referenced this pull request Mar 31, 2026
@aduh95
2026-04-01, Version 25.9.0 (Current)
8282409 
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) #61674
cli:
  * (SEMVER-MINOR) add `--max-heap-size` option (tannal) #58708
crypto:
  * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
repl:
  * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188
  * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) #61227
sea:
  * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158
stream:
  * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066
test_runner:
  * add exports option for module mocks (sangwook) #61727

PR-URL: #62522
aduh95 added a commit that referenced this pull request Mar 31, 2026
@aduh95
2026-04-01, Version 25.9.0 (Current)
9f5a2c9 
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) #61674
cli:
  * (SEMVER-MINOR) add `--max-heap-size` option (tannal) #58708
crypto:
  * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
repl:
  * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188
  * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) #61227
sea:
  * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158
stream:
  * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066
test_runner:
  * add exports option for module mocks (sangwook) #61727

PR-URL: #62522
aduh95 added a commit that referenced this pull request Apr 1, 2026
@aduh95
2026-04-01, Version 25.9.0 (Current)
86282b5 
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add using scopes to `AsyncLocalStorage` (Stephen Belanger) #61674
cli:
  * (SEMVER-MINOR) add `--max-heap-size` option (tannal) #58708
crypto:
  * (SEMVER-MINOR) add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
repl:
  * (SEMVER-MINOR) add customizable error handling (Anna Henningsen) #62188
  * (SEMVER-MINOR) remove dependency on `node:domain` (Matteo Collina) #61227
sea:
  * (SEMVER-MINOR) support code cache for ESM entrypoint in SEA (Joyee Cheung) #62158
stream:
  * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066
test_runner:
  * add exports option for module mocks (sangwook) #61727

PR-URL: #62522
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Apr 2, 2026