Skip to content

http: remove redundant keepAliveTimeoutBuffer assignment#61743

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:fix/remove-redundant-keepalivetimeoutbuffer-check
Feb 19, 2026
Merged

http: remove redundant keepAliveTimeoutBuffer assignment#61743
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:fix/remove-redundant-keepalivetimeoutbuffer-check

Conversation

@efekrskl
Copy link
Copy Markdown
Contributor

@efekrskl efekrskl commented Feb 8, 2026

storeHTTPOptions() (see lib/_http_server.js:496) already validates and initializes keepAliveTimeoutBuffer. This PR removes the redundant assignment so option validation and defaulting have a single source of truth.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Feb 8, 2026

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Feb 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 8, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.73%. Comparing base (1e8a639) to head (4e7c085).
⚠️ Report is 70 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #61743   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files         675      675           
  Lines      204525   204519    -6     
  Branches    39314    39304   -10     
=======================================
+ Hits       183523   183529    +6     
+ Misses      13300    13293    -7     
+ Partials     7702     7697    -5
Files with missing lines Coverage Δ
lib/_http_server.js 97.17% <ø> (+0.27%) ⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Feb 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 8, 2026
@Flarna Flarna added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 15, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Feb 18, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71366/

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 19, 2026
@nodejs-github-bot nodejs-github-bot merged commit 9d64cb6 into nodejs:main Feb 19, 2026
90 of 91 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Feb 19, 2026

Landed in 9d64cb6

aduh95 pushed a commit that referenced this pull request Feb 19, 2026
@efekrskl @aduh95
http: remove redundant keepAliveTimeoutBuffer assignment
2c94967 
PR-URL: #61743
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actions github-actions Bot mentioned this pull request Feb 22, 2026
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 2, 2026
@tmeijn
build(deps): update node.js to v25.7.0
3826422 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `25.6.1` → `25.7.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>nodejs/node (node)</summary>

### [`v25.7.0`](https://github.com/nodejs/node/releases/tag/v25.7.0): 2026-02-24, Version 25.7.0 (Current), @&#8203;ruyadorno prepared by @&#8203;aduh95

[Compare Source](nodejs/node@v25.6.1...v25.7.0)

##### Notable Changes

- \[[`b0a79b10f0`](nodejs/node@b0a79b10f0)] - **(SEMVER-MINOR)** **http2**: add http1Options for HTTP/1 fallback configuration (Amol Yadav) [#&#8203;61713](nodejs/node#61713)
- \[[`2d874dfb8e`](