Skip to content

src: move shared_ptr objects in KeyObjectData#59472

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-crypto-keyobjectdata-move
Aug 16, 2025
Merged

src: move shared_ptr objects in KeyObjectData#59472
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-crypto-keyobjectdata-move

Conversation

@tniessen
Copy link
Copy Markdown
Member

@tniessen tniessen commented Aug 14, 2025

Since copying shared_ptr may involve costly atomic operations when copied implicitly, explicitly move both shared_ptr objects that are passed to the private KeyObjectData constructor.

@tniessen
src: move shared_ptr objects in KeyObjectData
36324d6 
Since copying `shared_ptr` may involve costly atomic operations,
explicitly move both `shared_ptr` objects that are passed to the
private KeyObjectData constructor.
@tniessen tniessen added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 14, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Aug 14, 2025

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 14, 2025
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 14, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Aug 14, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68632/

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.87%. Comparing base (db18bc8) to head (36324d6).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59472      +/-   ##
==========================================
- Coverage   89.87%   89.87%   -0.01%     
==========================================
  Files         656      656              
  Lines      192956   192963       +7     
  Branches    37846    37850       +4     
==========================================
+ Hits       173411   173416       +5     
- Misses      12103    12114      +11     
+ Partials     7442     7433       -9
Files with missing lines Coverage Δ
src/crypto/crypto_keys.h 56.60% <100.00%> (ø)

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Aug 14, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68635/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Aug 15, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68647/

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit 80fb4fe into nodejs:main Aug 16, 2025
77 of 78 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Aug 16, 2025

Landed in 80fb4fe

panva pushed a commit to panva/node that referenced this pull request Aug 18, 2025
@tniessen @panva
src: move shared_ptr objects in KeyObjectData
5ff845a 
Since copying `shared_ptr` may involve costly atomic operations,
explicitly move both `shared_ptr` objects that are passed to the
private KeyObjectData constructor.

PR-URL: nodejs#59472
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Aug 21, 2025
@tniessen @targos
src: move shared_ptr objects in KeyObjectData
3e1551d 
Since copying `shared_ptr` may involve costly atomic operations,
explicitly move both `shared_ptr` objects that are passed to the
private KeyObjectData constructor.

PR-URL: #59472
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actions github-actions Bot mentioned this pull request Aug 26, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 28, 2025
@tmeijn