Skip to content

src: fix -Wreturn-stack-address error#58439

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:fix-wreturn-address
May 28, 2025
Merged

src: fix -Wreturn-stack-address error#58439
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:fix-wreturn-address

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented May 23, 2025

Refs #57016

Fixes the following:

../../third_party/electron_node/src/node_config_file.cc:26:16: error: returning address of local temporary object [-Werror,-Wreturn-stack-address]
   26 |         return it->substr(flag_path.size() + 1);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

@codebytere codebytere requested a review from marco-ippolito May 23, 2025 18:12
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels May 23, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (5ffcf6b) to head (3d0c700).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
src/node_config_file.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58439      +/-   ##
==========================================
- Coverage   90.22%   90.19%   -0.03%     
==========================================
  Files         635      635              
  Lines      187173   187224      +51     
  Branches    36747    36770      +23     
==========================================
  Hits       168870   168870              
- Misses      11071    11120      +49     
- Partials     7232     7234       +2
Files with missing lines Coverage Δ
src/node_config_file.cc 73.38% <0.00%> (ø)

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 24, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67034/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67092/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67157/

@codebytere codebytere added the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2025
@nodejs-github-bot nodejs-github-bot merged commit 47081ee into nodejs:main May 28, 2025
77 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 28, 2025

Landed in 47081ee

targos pushed a commit that referenced this pull request May 31, 2025
@codebytere @targos
src: fix -Wreturn-stack-address error
440d4f4 
PR-URL: #58439
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actions github-actions Bot mentioned this pull request Jun 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@codebytere @aduh95
src: fix -Wreturn-stack-address error
eb143e9 
PR-URL: #58439
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 16, 2025
@tmeijn