Skip to content

test: fix test-buffer-tostring-range on allocation failure#58416

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fix-buffer-tostring-4gb
May 23, 2025
Merged

test: fix test-buffer-tostring-range on allocation failure#58416
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fix-buffer-tostring-4gb

Conversation

@joyeecheung
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung commented May 21, 2025

If the test cannot allocate a buffer over 4GB, there is no point continue testing toString() on it.

This also split the test case to a different file for clarity and reduce interference with other cases.

Fixes: #56726

@joyeecheung
test: fix test-buffer-tostring-range on allocation failure
4b1dbf7 
If the test cannot allocate a buffer over 4GB, there is no point
continue testing toString() on it.

This also split the test case to a different file for clarity and
reduce interference with other cases.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 21, 2025
@joyeecheung joyeecheung mentioned this pull request May 21, 2025
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (2dcbd78) to head (4b1dbf7).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58416      +/-   ##
==========================================
- Coverage   90.22%   90.19%   -0.03%     
==========================================
  Files         635      635              
  Lines      187171   187171              
  Branches    36755    36747       -8     
==========================================
- Hits       168869   168823      -46     
- Misses      11075    11120      +45     
- Partials     7227     7228       +1

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66998/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 22, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67001/

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit e9c6004 into nodejs:main May 23, 2025
73 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 23, 2025

Landed in e9c6004

targos pushed a commit that referenced this pull request May 31, 2025
@joyeecheung @targos
test: fix test-buffer-tostring-range on allocation failure
4629b18 
If the test cannot allocate a buffer over 4GB, there is no point
continue testing toString() on it.

This also split the test case to a different file for clarity and
reduce interference with other cases.

PR-URL: #58416
Fixes: #56726
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actions github-actions Bot mentioned this pull request Jun 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@joyeecheung @aduh95
test: fix test-buffer-tostring-range on allocation failure
b3e0cf1 
If the test cannot allocate a buffer over 4GB, there is no point
continue testing toString() on it.

This also split the test case to a different file for clarity and
reduce interference with other cases.

PR-URL: #58416
Fixes: #56726
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 16, 2025
@tmeijn