Skip to content

test: do not skip OCB decryption in FIPS mode#58382

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-do-not-skip-ocb-in-fips
May 21, 2025
Merged

test: do not skip OCB decryption in FIPS mode#58382
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-do-not-skip-ocb-in-fips

Conversation

@tniessen
Copy link
Copy Markdown
Member

@tniessen tniessen commented May 19, 2025

I believe that OCB should work in FIPS mode, and only CCM should be skipped here.

@tniessen
test: do not skip OCB decryption in FIPS mode
d68ca5c 
I believe that OCB should work in FIPS mode, and only CCM should be
skipped here.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 19, 2025
@tniessen tniessen added the crypto Issues and PRs related to the crypto subsystem. label May 19, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (20c4b80) to head (d68ca5c).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58382   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         633      633           
  Lines      186883   186883           
  Branches    36695    36684   -11     
=======================================
+ Hits       168632   168643   +11     
+ Misses      11040    11039    -1     
+ Partials     7211     7201   -10

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 19, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66954/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2025
@nodejs-github-bot nodejs-github-bot merged commit 283ed53 into nodejs:main May 21, 2025
73 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 21, 2025

Landed in 283ed53

targos pushed a commit that referenced this pull request May 31, 2025
@tniessen @targos
test: do not skip OCB decryption in FIPS mode
d05263e 
I believe that OCB should work in FIPS mode, and only CCM should be
skipped here.

PR-URL: #58382
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions Bot mentioned this pull request Jun 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@tniessen @aduh95
test: do not skip OCB decryption in FIPS mode
9af3054 
I believe that OCB should work in FIPS mode, and only CCM should be
skipped here.

PR-URL: #58382
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 16, 2025
@tmeijn
build(deps): update node to v24.2.0
72e3ec7 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `2