Skip to content

test: remove references to create(De|C)ipher#58363

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-crypto-auth-remove-cipher-refs
May 18, 2025
Merged

test: remove references to create(De|C)ipher#58363
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-crypto-auth-remove-cipher-refs

Conversation

@tniessen
Copy link
Copy Markdown
Member

@tniessen tniessen commented May 16, 2025

Both createCipher() and createDecipher() were removed in Node.js 22.

@tniessen
test: remove references to create(De|C)ipher
cb802dd 
Both `createCipher()` and `createDecipher()` were removed in Node.js 22.
@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. labels May 16, 2025
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 16, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (a436f7b) to head (cb802dd).
Report is 28 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58363      +/-   ##
==========================================
- Coverage   90.24%   90.22%   -0.02%     
==========================================
  Files         633      633              
  Lines      186859   186859              
  Branches    36685    36677       -8     
==========================================
- Hits       168622   168597      -25     
- Misses      11036    11041       +5     
- Partials     7201     7221      +20

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 17, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66858/

@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 17, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2025
@nodejs-github-bot nodejs-github-bot merged commit 61aecf2 into nodejs:main May 18, 2025
81 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 18, 2025

Landed in 61aecf2

targos pushed a commit that referenced this pull request May 31, 2025
@tniessen @targos
test: remove references to create(De|C)ipher
4ae6a1a 
Both `createCipher()` and `createDecipher()` were removed in Node.js 22.

PR-URL: #58363
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions Bot mentioned this pull request Jun 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@tniessen @aduh95
test: remove references to create(De|C)ipher
f18041a 
Both `createCipher()` and `createDecipher()` were removed in Node.js 22.

PR-URL: #58363
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 16, 2025
@tmeijn