Skip to content

src: fix typo in comment#57291

Closed
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fix-typo
Closed

src: fix typo in comment#57291
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fix-typo

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Mar 3, 2025

No description provided.

@aduh95 aduh95 requested a review from legendecas March 3, 2025 13:51
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Mar 3, 2025
@aduh95 aduh95 added fast-track PRs that do not need to wait for 72 hours to land. and removed needs-ci PRs that need a full CI run. labels Mar 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2025

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 mentioned this pull request Mar 3, 2025
Merged
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (47a59bd) to head (4bb293e).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57291      +/-   ##
==========================================
+ Coverage   90.24%   90.26%   +0.01%     
==========================================
  Files         630      630              
  Lines      184920   184920              
  Branches    36186    36187       +1     
==========================================
+ Hits       166874   166910      +36     
+ Misses      11059    11050       -9     
+ Partials     6987     6960      -27
Files with missing lines Coverage Δ
src/node_util.cc 82.04% <ø> (ø)

... and 28 files with indirect coverage changes

@jakecastelli jakecastelli added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 4, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 4, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 4, 2025

Commit Queue failed
- Loading data for nodejs/node/pull/57291
✔  Done loading data for nodejs/node/pull/57291
----------------------------------- PR info ------------------------------------
Title      src: fix typo in comment (#57291)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:fix-typo -> nodejs:main
Labels     util, c++, fast-track, author ready
Commits    1
 - src: fix typo in comment
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/57291
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57291
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 03 Mar 2025 13:51:42 GMT
   ✔  Approvals: 3
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/57291#pullrequestreview-2654242823
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/57291#pullrequestreview-2654385334
   ✔  - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/57291#pullrequestreview-2657770409
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/13655797837

@jakecastelli
Copy link
Copy Markdown
Member

jakecastelli commented Mar 4, 2025

I knew it, cq probably should check for request-ci label and on the safer side have another around approval for changes that don't need a full CI run.

@jakecastelli jakecastelli removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 4, 2025
jakecastelli pushed a commit that referenced this pull request Mar 4, 2025
@aduh95 @jakecastelli
src: fix typo in comment
559d481 
PR-URL: #57291
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@jakecastelli
Copy link
Copy Markdown
Member

jakecastelli commented Mar 4, 2025

Landed in 559d481

@jakecastelli jakecastelli mentioned this pull request Mar 4, 2025
Closed
aduh95 added a commit that referenced this pull request Mar 9, 2025
@aduh95
src: fix typo in comment
ad6c6d1 
PR-URL: #57291
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 added a commit that referenced this pull request Mar 9, 2025
@aduh95
src: fix typo in comment
17c9e76 
PR-URL: #57291
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@github-actions github-actions Bot mentioned this pull request Mar 12, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 24, 2025
@tmeijn