Skip to content

test: mark test-without-async-context-frame flaky on windows#56753

Closed
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:jasnell/flaky-test-without-async-context-frame-win
Closed

test: mark test-without-async-context-frame flaky on windows#56753
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:jasnell/flaky-test-without-async-context-frame-win

Conversation

@jasnell
Copy link
Copy Markdown
Member

@jasnell jasnell commented Jan 24, 2025

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 24, 2025
jasnell
jasnell commented Jan 24, 2025
View reviewed changes
Comment thread test/parallel/parallel.status
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 24, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/64724/ 💛

@jasnell jasnell mentioned this pull request Jan 24, 2025
Closed
@jasnell jasnell requested review from anonrig and mcollina January 24, 2025 18:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (c752615) to head (3bbb0b8).
Report is 47 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56753   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         662      662           
  Lines      191976   191976           
  Branches    36950    36952    +2     
=======================================
+ Hits       171271   171277    +6     
- Misses      13545    13552    +7     
+ Partials     7160     7147   -13

see 40 files with indirect coverage changes

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 24, 2025
@Flarna Flarna added the async_local_storage AsyncLocalStorage label Jan 28, 2025
jasnell added a commit that referenced this pull request Jan 29, 2025
@jasnell
test: mark test-without-async-context-frame flaky on windows
7a4e9e6 
Refs: #56751
Refs: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32254/RUN_SUBSET=0,nodes=win2019-COMPILED_BY-vs2022/testReport/(root)/parallel/test_without_async_context_frame/
PR-URL: #56753
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented Jan 29, 2025

Landed in 7a4e9e6

@jasnell jasnell closed this Jan 29, 2025
@jasnell jasnell removed the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 29, 2025
targos pushed a commit that referenced this pull request Feb 2, 2025
@jasnell @targos
test: mark test-without-async-context-frame flaky on windows
c8bd2ba 
Refs: #56751
Refs: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32254/RUN_SUBSET=0,nodes=win2019-COMPILED_BY-vs2022/testReport/(root)/parallel/test_without_async_context_frame/
PR-URL: #56753
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@github-actions github-actions Bot mentioned this pull request Feb 11, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 25, 2025
@tmeijn
build(deps): update node to v23.8.0
c6210ee 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `23.7.0` -> `23.8.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>nodejs/node (node)</summary>

### [`v23.8.0`](https://github.com/nodejs/node/releases/tag/v23.8.0): 2025-02-13, Version 23.8.0 (Current), @&#8203;targos

[Compare Source](nodejs/node@v23.7.0...v23.8.0)

##### Notable Changes

##### Support for using system CA certificates store on macOS and Windows

This version adds the `--use-system-ca` command-line flag, which instructs Node.js
to use the trusted CA certificates present in the system store along with
the `--use-bundled-ca`, `--use-openssl-ca` options.

This option is available on macOS and Windows for now.

Contributed by Tim Jacomb in [#&#8203;56599](nodejs/node#56599)
and Joyee Cheung in [#&#8203;56833](nodejs/node#56833).

##### Introduction of the URL Pattern API

An implementation of the [URL Pattern API](https://developer.mozilla.org/en-US/docs/Web/API/URL_Pattern_API)
is now available.

The `URLPattern` constructor is exported from the `node:url` module and will be
available as a global in Node.js 24.

Contributed by Yagiz Nizipli and Daniel Lemire in [#&#8203;56452](nodejs/node#56452).

##### Support for the zstd compression algorithm

Node.js now includes support for the Zstandard (zstd) compression algorithm.
Various APIs have been added to the `node:zlib` module for both compression and decompression
of zstd streams.

Contributed by Jan Krems in [#&#8203;52100](nodejs/node#52100).

##### Node.js thread names

Threads created by the Node.js process are now named to improve the debugging experience.
Worker threads will use the `name` option that can be passed to the `Worker` constructor.

Contributed by Rafael Gonzaga in [#&#8203;56416](nodejs/node#56416).

##### Timezone data has been updated to 2025a

Included changes:

-   Paraguay adopts permanent -03 starting spring 2024.
-   Improve pre-1991 data for the Philippines.

##### Other Notable Changes

-   \[[`39997867cf`](nodejs/node@39997867cf)] - **(SEMVER-MINOR)** **sqlite**: allow returning `ArrayBufferView`s from user-defined functions (René) [#&#8203;56790](nodejs/node#56790)

##### Commits

-   \[[`0ee9c34d63`](nodejs/node@0ee9c34d63)] - **benchmark**: add simple parse and test benchmarks for URLPattern (James M Snell) [#&#8203;56882](nodejs/node#56882)
-   \[[`b3f2045d14`](nodejs/node@b3f2045d14)] - **build**: gyp exclude libm linking on macOS (deepak1556) [#&#8203;56901](nodejs/node#56901)
-   \[[`e0dd9aefd6`](nodejs/node@e0dd9aefd6)] - **build**: remove explicit linker call to libm on macOS (deepak1556) [#&#8203;56901](nodejs/node#56901)
-   \[[`52399da780`](nodejs/node@52399da780)] - **build**: link with Security.framework in GN build (Cheng) [#&#8203;56895](nodejs/node#56895)
-   \[[`582b9221c9`](nodejs/node@582b9221c9)] - **build**: do not put commands in sources variables (Cheng) [#&#8203;56885](nodejs/node#56885)
-   \[[`ea61b956e9`](nodejs/node@ea61b956e9)] - **build**: add double quotes around <(python) (Luigi Pinca) [#&#8203;56826](nodejs/node#56826)
-   \[[`14236ef778`](nodejs/node@14236ef778)] - **build**: add build option suppress_all_error_on_warn (Michael Dawson) [#&#8203;56647](nodejs/node#56647)
-   \[[`dfd3f430f3`](nodejs/node@dfd3f430f3)] - **build,win**: enable ccache (Stefan Stojanovic) [#&#8203;56847](nodejs/node#56847)
-   \[[`3e207bd9ec`](nodejs/node@3e207bd9ec)] - **(SEMVER-MINOR)** **crypto**: support --use-system-ca on Windows (Joyee Cheung) [#&#8203;56833](nodejs/node#56833)
-   \[[`fe2694a992`](nodejs/node@fe2694a992)] - **crypto**: fix X509\* leak in --use-system-ca (Joyee Cheung) [#&#8203;56832](nodejs/node#56832)
-   \[[`60039a2c36`](nodejs/node@60039a2c36)] - **crypto**: add api to get openssl security level (Michael Dawson) [#&#8203;56601](nodejs/node#56601)
-   \[[`39a474f7c0`](nodejs/node@39a474f7c0)] - **(SEMVER-MINOR)** **crypto**: added support for reading certificates from macOS system store (Tim Jacomb) [#&#8203;56599](nodejs/node#56599)
-   \[[`144bee8067`](nodejs/node@144bee8067)] - **deps**: update zlib to 1.3.0.1-motley-788cb3c (Node.js GitHub Bot) [#&#8203;56655](nodejs/node#56655)
-   \[[`7fd39e3a79`](nodejs/node@7fd39e3a79)] - **deps**: update sqlite to 3.49.0 (Node.js GitHub Bot) [#&#8203;56654](nodejs/node#56654)
-   \[[`d698cb5434`](nodejs/node@d698cb5434)] - **deps**: update amaro to 0.3.2 (marco-ippolito) [#&#8203;56916](nodejs/node#56916)
-   \[[`dbd09067c0`](nodejs/node@dbd09067c0)] - **deps**: V8: cherry-pick [`9ab4059`](nodejs/node@9ab40592f697) (Levi Zim) [#&#8203;56781](nodejs/node#56781)
-   \[[`ee33ef3aa6`](nodejs/node@ee33ef3aa6)] - **deps**: update cjs-module-lexer to 2.0.0 (Michael Dawson) [#&#8203;56855](nodejs/node#56855)
-   \[[`c0542557d0`](nodejs/node@c0542557d0)] - **deps**: update timezone to 2025a (Node.js GitHub Bot) [#&#8203;56876](nodejs/node#56876)
-   \[[`d67cb1f9bb`](nodejs/node@d67cb1f9bb)] - **deps**: update simdjson to 3.12.0 (Node.js GitHub Bot) [#&#8203;56874](nodejs/node#56874)
-   \[[`70b04b4314`](nodejs/node@70b04b4314)] - **deps**: update