Skip to content

tools: do not throw on missing create-release-proposal.sh#56695

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-create-release-proposal
Jan 22, 2025
Merged

tools: do not throw on missing create-release-proposal.sh#56695
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-create-release-proposal

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Jan 22, 2025

No description provided.

@aduh95 aduh95 requested a review from a team as a code owner January 22, 2025 11:34
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 22, 2025

Review requested:

  • @nodejs/actions
  • @nodejs/releasers

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 22, 2025
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 72 hours to land. label Jan 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2025

Fast-track has been requested by @aduh95. Please 👍 to approve.

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 22, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1c5b7e1 into nodejs:main Jan 22, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 22, 2025

Landed in 1c5b7e1

@marco-ippolito
Copy link
Copy Markdown
Member

marco-ippolito commented Jan 22, 2025

unfortunately its still failing https://github.com/nodejs/node/actions/runs/12908724429/job/35994848788

@targos
Copy link
Copy Markdown
Member

targos commented Jan 22, 2025

Wouldn't it be easier/better to cherry-pick the commit that adds the file?

@aduh95 aduh95 deleted the fix-create-release-proposal branch January 22, 2025 13:59
@aduh95 aduh95 mentioned this pull request Jan 22, 2025
Merged
@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Jan 22, 2025

Wouldn't it be easier/better to cherry-pick the commit that adds the file?

The goal is for the action to work even when changes to the action haven't been backported

aduh95 added a commit that referenced this pull request Jan 27, 2025
@aduh95
tools: do not throw on missing create-release-proposal.sh
7aed11b 
PR-URL: #56695
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
@github-actions github-actions Bot mentioned this pull request Jan 28, 2025
Merged
aduh95 added a commit that referenced this pull request Jan 30, 2025
@aduh95
tools: do not throw on missing create-release-proposal.sh
02f36ca 
PR-URL: #56695
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
aduh95 added a commit that referenced this pull request Jan 31, 2025
@aduh95
tools: do not throw on missing create-release-proposal.sh
80217c9 
PR-URL: #56695
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
aduh95 added a commit that referenced this pull request Feb 4, 2025
@aduh95
tools: do not throw on missing create-release-proposal.sh
d8da1ec 
PR-URL: #56695
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
@github-actions github-actions Bot mentioned this pull request Feb 4, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 4, 2025
@tmeijn