tools: validate commit list as part of lint-release-commit#56291
Merged
Conversation
Collaborator
|
Review requested:
|
richardlau
reviewed
Dec 17, 2024
ruyadorno
reviewed
Dec 18, 2024
jasnell
approved these changes
Dec 28, 2024
Contributor
Author
|
@nodejs/releasers I'm planing on landing this later this week if I don't receive more feedback on it |
Collaborator
|
Landed in e1df1e0 |
targos
pushed a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #56291 Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Jan 13, 2025
PR-URL: nodejs#56291 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 30, 2025
PR-URL: #56291 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 31, 2025
PR-URL: #56291 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
added a commit
that referenced
this pull request
Feb 4, 2025
PR-URL: #56291 Reviewed-By: James M Snell <jasnell@gmail.com>
When updating manually a release proposal, it can be easy to have the commit list in the CHANGELOG and the actual list of commits in the proposal no longer in sync.
It will also double check that none of the commits being released comes from a PR with the
dont-land-onvXX.x, in case the label was added after the commit was already backported.I'm also switching to using
make release-onlywhich contains the checks we were doing and more.You can test it locally while the v23.5.0 proposal is open: